admin/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-02-15 10:53:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: use readFile utility in hooks and add pattern type safety

Browse Source 
- Replace raw fs.readFileSync with readFile() from utils in
  check-console-log.js and post-edit-console-warn.js to eliminate
  TOCTOU race conditions (file deleted between existsSync and read)
- Remove redundant existsSync in post-edit-format.js (exec already
  handles missing files via its catch block)
- Resolve path upfront in post-edit-typecheck.js before tsconfig walk
- Add type guard in getGitModifiedFiles() to skip non-string and
  empty patterns before regex compilation
This commit is contained in:
Affaan Mustafa
2026-02-12 15:28:30 -08:00
parent 911d38f686
commit e7b5c62eb7
5 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/hooks/check-console-log.js
View File

@@ -14,7 +14,7 @@
*/
const fs = require('fs');
const { isGitRepo, getGitModifiedFiles, log } = require('../lib/utils');
const { isGitRepo, getGitModifiedFiles, readFile, log } = require('../lib/utils');
// Files where console.log is expected and should not trigger warnings
const EXCLUDED_PATTERNS = [
@@ -49,8 +49,8 @@ process.stdin.on('end', () => {
let hasConsole = false;
for (const file of files) {
const content = fs.readFileSync(file, 'utf8');
if (content.includes('console.log')) {
const content = readFile(file);
if (content && content.includes('console.log')) {
log(`[Hook] WARNING: console.log found in ${file}`);
hasConsole = true;
}

6
scripts/hooks/post-edit-console-warn.js
View File

@@ -10,6 +10,7 @@
*/
const fs = require('fs');
const { readFile } = require('../lib/utils');
const MAX_STDIN = 1024 * 1024; // 1MB limit
let data = '';
@@ -25,8 +26,9 @@ process.stdin.on('end', () => {
const input = JSON.parse(data);
const filePath = input.tool_input?.file_path;
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath) && fs.existsSync(filePath)) {
const content = fs.readFileSync(filePath, 'utf8');
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath)) {
const content = readFile(filePath);
if (!content) { console.log(data); return; }
const lines = content.split('\n');
const matches = [];

4
scripts/hooks/post-edit-format.js
View File

@@ -25,14 +25,14 @@ process.stdin.on('end', () => {
const input = JSON.parse(data);
const filePath = input.tool_input?.file_path;
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath) && fs.existsSync(filePath)) {
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath)) {
try {
execFileSync('npx', ['prettier', '--write', filePath], {
stdio: ['pipe', 'pipe', 'pipe'],
timeout: 15000
});
} catch {
// Prettier not installed or failed — non-blocking
// Prettier not installed, file missing, or failed — non-blocking
}
}
} catch {

6
scripts/hooks/post-edit-typecheck.js
View File

@@ -27,9 +27,11 @@ process.stdin.on('end', () => {
const input = JSON.parse(data);
const filePath = input.tool_input?.file_path;
if (filePath && /\.(ts|tsx)$/.test(filePath) && fs.existsSync(filePath)) {
if (filePath && /\.(ts|tsx)$/.test(filePath)) {
const resolvedPath = path.resolve(filePath);
if (!fs.existsSync(resolvedPath)) { console.log(data); return; }
// Find nearest tsconfig.json by walking up (max 20 levels to prevent infinite loop)
let dir = path.dirname(path.resolve(filePath));
let dir = path.dirname(resolvedPath);
const root = path.parse(dir).root;
let depth = 0;