fix: use readFile utility in hooks and add pattern type safety

- Replace raw fs.readFileSync with readFile() from utils in
  check-console-log.js and post-edit-console-warn.js to eliminate
  TOCTOU race conditions (file deleted between existsSync and read)
- Remove redundant existsSync in post-edit-format.js (exec already
  handles missing files via its catch block)
- Resolve path upfront in post-edit-typecheck.js before tsconfig walk
- Add type guard in getGitModifiedFiles() to skip non-string and
  empty patterns before regex compilation
This commit is contained in:
Affaan Mustafa
2026-02-12 15:28:30 -08:00
parent 911d38f686
commit e7b5c62eb7
5 changed files with 14 additions and 9 deletions

View File

@@ -10,6 +10,7 @@
*/
const fs = require('fs');
const { readFile } = require('../lib/utils');
const MAX_STDIN = 1024 * 1024; // 1MB limit
let data = '';
@@ -25,8 +26,9 @@ process.stdin.on('end', () => {
const input = JSON.parse(data);
const filePath = input.tool_input?.file_path;
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath) && fs.existsSync(filePath)) {
const content = fs.readFileSync(filePath, 'utf8');
if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath)) {
const content = readFile(filePath);
if (!content) { console.log(data); return; }
const lines = content.split('\n');
const matches = [];