mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-02-15 19:03:22 +08:00
Bug fixes: - utils.js: prevent duplicate 'g' flag in countInFile regex construction - validate-agents.js: handle CRLF line endings in frontmatter parsing - validate-hooks.js: handle \t and \\ escape sequences in inline JS validation - session-aliases.js: prevent NaN in date sort when timestamps are missing - session-aliases.js: persist rollback on rename failure instead of silent loss - session-manager.js: require absolute paths in getSessionStats to prevent content strings ending with .tmp from being treated as file paths New tests (164 total, up from 97): - session-manager.test.js: 27 tests covering parseSessionFilename, parseSessionMetadata, getSessionStats, CRUD operations, getSessionSize, getSessionTitle, edge cases (null input, non-existent files, directories) - session-aliases.test.js: 40 tests covering loadAliases (corrupted JSON, invalid structure), setAlias (validation, reserved names), resolveAlias, listAliases (sort, search, limit), deleteAlias, renameAlias, updateAliasTitle, resolveSessionAlias, getAliasesForSession, cleanupAliases, atomic write Also includes hook-generated improvements: - utils.d.ts: document that readStdinJson never rejects - session-aliases.d.ts: fix updateAliasTitle type to accept null - package-manager.js: add try-catch to setProjectPackageManager writeFile
140 lines
4.9 KiB
JavaScript
140 lines
4.9 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* Validate hooks.json schema
|
|
*/
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const vm = require('vm');
|
|
|
|
const HOOKS_FILE = path.join(__dirname, '../../hooks/hooks.json');
|
|
const VALID_EVENTS = ['PreToolUse', 'PostToolUse', 'PreCompact', 'SessionStart', 'SessionEnd', 'Stop', 'Notification', 'SubagentStop'];
|
|
|
|
function validateHooks() {
|
|
if (!fs.existsSync(HOOKS_FILE)) {
|
|
console.log('No hooks.json found, skipping validation');
|
|
process.exit(0);
|
|
}
|
|
|
|
let data;
|
|
try {
|
|
data = JSON.parse(fs.readFileSync(HOOKS_FILE, 'utf-8'));
|
|
} catch (e) {
|
|
console.error(`ERROR: Invalid JSON in hooks.json: ${e.message}`);
|
|
process.exit(1);
|
|
}
|
|
|
|
// Support both object format { hooks: {...} } and array format
|
|
const hooks = data.hooks || data;
|
|
let hasErrors = false;
|
|
let totalMatchers = 0;
|
|
|
|
if (typeof hooks === 'object' && !Array.isArray(hooks)) {
|
|
// Object format: { EventType: [matchers] }
|
|
for (const [eventType, matchers] of Object.entries(hooks)) {
|
|
if (!VALID_EVENTS.includes(eventType)) {
|
|
console.error(`ERROR: Invalid event type: ${eventType}`);
|
|
hasErrors = true;
|
|
continue;
|
|
}
|
|
|
|
if (!Array.isArray(matchers)) {
|
|
console.error(`ERROR: ${eventType} must be an array`);
|
|
hasErrors = true;
|
|
continue;
|
|
}
|
|
|
|
for (let i = 0; i < matchers.length; i++) {
|
|
const matcher = matchers[i];
|
|
if (typeof matcher !== 'object' || matcher === null) {
|
|
console.error(`ERROR: ${eventType}[${i}] is not an object`);
|
|
hasErrors = true;
|
|
continue;
|
|
}
|
|
if (!matcher.matcher) {
|
|
console.error(`ERROR: ${eventType}[${i}] missing 'matcher' field`);
|
|
hasErrors = true;
|
|
}
|
|
if (!matcher.hooks || !Array.isArray(matcher.hooks)) {
|
|
console.error(`ERROR: ${eventType}[${i}] missing 'hooks' array`);
|
|
hasErrors = true;
|
|
} else {
|
|
// Validate each hook entry
|
|
for (let j = 0; j < matcher.hooks.length; j++) {
|
|
const hook = matcher.hooks[j];
|
|
if (!hook.type || typeof hook.type !== 'string') {
|
|
console.error(`ERROR: ${eventType}[${i}].hooks[${j}] missing or invalid 'type' field`);
|
|
hasErrors = true;
|
|
}
|
|
if (!hook.command || (typeof hook.command !== 'string' && !Array.isArray(hook.command))) {
|
|
console.error(`ERROR: ${eventType}[${i}].hooks[${j}] missing or invalid 'command' field`);
|
|
hasErrors = true;
|
|
} else if (typeof hook.command === 'string') {
|
|
// Validate inline JS syntax in node -e commands
|
|
const nodeEMatch = hook.command.match(/^node -e "(.*)"$/s);
|
|
if (nodeEMatch) {
|
|
try {
|
|
new vm.Script(nodeEMatch[1].replace(/\\"/g, '"').replace(/\\n/g, '\n').replace(/\\t/g, '\t').replace(/\\\\/g, '\\'));
|
|
} catch (syntaxErr) {
|
|
console.error(`ERROR: ${eventType}[${i}].hooks[${j}] has invalid inline JS: ${syntaxErr.message}`);
|
|
hasErrors = true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
totalMatchers++;
|
|
}
|
|
}
|
|
} else if (Array.isArray(hooks)) {
|
|
// Array format (legacy)
|
|
for (let i = 0; i < hooks.length; i++) {
|
|
const hook = hooks[i];
|
|
if (!hook.matcher) {
|
|
console.error(`ERROR: Hook ${i} missing 'matcher' field`);
|
|
hasErrors = true;
|
|
}
|
|
if (!hook.hooks || !Array.isArray(hook.hooks)) {
|
|
console.error(`ERROR: Hook ${i} missing 'hooks' array`);
|
|
hasErrors = true;
|
|
} else {
|
|
// Validate each hook entry
|
|
for (let j = 0; j < hook.hooks.length; j++) {
|
|
const h = hook.hooks[j];
|
|
if (!h.type || typeof h.type !== 'string') {
|
|
console.error(`ERROR: Hook ${i}.hooks[${j}] missing or invalid 'type' field`);
|
|
hasErrors = true;
|
|
}
|
|
if (!h.command || (typeof h.command !== 'string' && !Array.isArray(h.command))) {
|
|
console.error(`ERROR: Hook ${i}.hooks[${j}] missing or invalid 'command' field`);
|
|
hasErrors = true;
|
|
} else if (typeof h.command === 'string') {
|
|
// Validate inline JS syntax in node -e commands
|
|
const nodeEMatch = h.command.match(/^node -e "(.*)"$/s);
|
|
if (nodeEMatch) {
|
|
try {
|
|
new vm.Script(nodeEMatch[1].replace(/\\"/g, '"').replace(/\\n/g, '\n').replace(/\\t/g, '\t').replace(/\\\\/g, '\\'));
|
|
} catch (syntaxErr) {
|
|
console.error(`ERROR: Hook ${i}.hooks[${j}] has invalid inline JS: ${syntaxErr.message}`);
|
|
hasErrors = true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
totalMatchers++;
|
|
}
|
|
} else {
|
|
console.error('ERROR: hooks.json must be an object or array');
|
|
process.exit(1);
|
|
}
|
|
|
|
if (hasErrors) {
|
|
process.exit(1);
|
|
}
|
|
|
|
console.log(`Validated ${totalMatchers} hook matchers`);
|
|
}
|
|
|
|
validateHooks();
|