chore(lint): upgrade linter from v1.56.2 to v1.61.0

- Remove no longer needed exclude rules
- Add new exclude rules for printf govet errors
- Remove deprecated linters `execinquery` and `exportloopref`
- Rename linter `goerr113` to `err113`
- Rename linter `gomnd` to `mnd`
This commit is contained in:
Quentin McGaw
2024-10-11 18:05:40 +00:00
parent 694988b32f
commit 3c8e80a1a4
76 changed files with 118 additions and 115 deletions

View File

@@ -6,7 +6,8 @@ import (
)
func (c *Configurator) WriteConfig(lines []string) error {
file, err := os.OpenFile(c.configPath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0644)
const permission = 0644
file, err := os.OpenFile(c.configPath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, permission)
if err != nil {
return err
}

View File

@@ -88,7 +88,7 @@ var (
func extractProto(line string) (protocol string, err error) {
fields := strings.Fields(line)
if len(fields) != 2 { //nolint:gomnd
if len(fields) != 2 { //nolint:mnd
return "", fmt.Errorf("%w: %s", errProtoLineFieldsCount, line)
}
@@ -124,7 +124,7 @@ func extractRemote(line string) (ip netip.Addr, port uint16,
// the firewall before the VPN is up.
}
if n > 2 { //nolint:gomnd
if n > 2 { //nolint:mnd
portInt, err := strconv.Atoi(fields[2])
if err != nil {
return netip.Addr{}, 0, "", fmt.Errorf("%w: %s", errPortNotValid, line)
@@ -134,7 +134,7 @@ func extractRemote(line string) (ip netip.Addr, port uint16,
port = uint16(portInt)
}
if n > 3 { //nolint:gomnd
if n > 3 { //nolint:mnd
switch fields[3] {
case "tcp", "udp":
protocol = fields[3]

View File

@@ -75,6 +75,6 @@ That error usually happens because either:
level = levelWarn
}
filtered = constants.ColorOpenvpn().Sprintf(filtered)
filtered = constants.ColorOpenvpn().Sprint(filtered)
return filtered, level
}

View File

@@ -25,7 +25,7 @@ func (c cipherDESCBC) IVSize() int {
}
func (c cipherDESCBC) KeySize() int {
return 8 //nolint:gomnd
return 8 //nolint:mnd
}
func (c cipherDESCBC) OID() asn1.ObjectIdentifier {