updater: refactoring and set DNS server correctly

- Fix CLI operation not setting DNS server
- Fix periodic operation not setting DNS server
- Set DNS address for resolution once at start for both CLI and periodic operation
- Inject resolver to each provider instead of creating it within
- Use resolver settings on every call to `.Resolve` method, instead of passing it to constructor
- Move out minServers check from resolver

internal/provider/vyprvpn/updater/resolve.go

@@ -6,7 +6,7 @@ import (
 	"github.com/qdm12/gluetun/internal/updater/resolver"
 )
 
-func newParallelResolver() (parallelResolver *resolver.Parallel) {
+func parallelResolverSettings(hosts []string) (settings resolver.ParallelSettings) {
 	const (
 		maxFailRatio    = 0.1
 		maxDuration     = 5 * time.Second
@@ -14,7 +14,8 @@ func newParallelResolver() (parallelResolver *resolver.Parallel) {
 		maxNoNew        = 2
 		maxFails        = 2
 	)
-	settings := resolver.ParallelSettings{
+	return resolver.ParallelSettings{
+		Hosts:        hosts,
 		MaxFailRatio: maxFailRatio,
 		Repeat: resolver.RepeatSettings{
 			MaxDuration:     maxDuration,
@@ -24,5 +25,4 @@ func newParallelResolver() (parallelResolver *resolver.Parallel) {
 			SortIPs:         true,
 		},
 	}
-	return resolver.NewParallelResolver(settings)
 }

internal/provider/vyprvpn/updater/servers.go

@@ -64,7 +64,8 @@ func (u *Updater) FetchServers(ctx context.Context, minServers int) (
 	}
 
 	hosts := hts.toHostsSlice()
-	hostToIPs, warnings, err := u.presolver.Resolve(ctx, hosts, minServers)
+	resolveSettings := parallelResolverSettings(hosts)
+	hostToIPs, warnings, err := u.presolver.Resolve(ctx, resolveSettings)
 	for _, warning := range warnings {
 		u.warner.Warn(warning)
 	}
@@ -72,15 +73,15 @@ func (u *Updater) FetchServers(ctx context.Context, minServers int) (
 		return nil, err
 	}
 
-	hts.adaptWithIPs(hostToIPs)
-
-	servers = hts.toServersSlice()
-
-	if len(servers) < minServers {
+	if len(hostToIPs) < minServers {
 		return nil, fmt.Errorf("%w: %d and expected at least %d",
 			common.ErrNotEnoughServers, len(servers), minServers)
 	}
 
+	hts.adaptWithIPs(hostToIPs)
+
+	servers = hts.toServersSlice()
+
 	sort.Sort(models.SortableServers(servers))
 
 	return servers, nil

internal/provider/vyprvpn/updater/updater.go

@@ -10,10 +10,11 @@ type Updater struct {
 	warner    common.Warner
 }
 
-func New(unzipper common.Unzipper, warner common.Warner) *Updater {
+func New(unzipper common.Unzipper, warner common.Warner,
+	parallelResolver common.ParallelResolver) *Updater {
 	return &Updater{
 		unzipper:  unzipper,
-		presolver: newParallelResolver(),
+		presolver: parallelResolver,
 		warner:    warner,
 	}
 }