chore(settings): use generics for helping functions (#1427)

internal/configuration/settings/helpers/override.go

@@ -1,19 +1,15 @@
 package helpers
 
 import (
-	"fmt"
 	"net/http"
 	"net/netip"
-	"time"
-
-	"github.com/qdm12/log"
 )
 
-func OverrideWithBool(existing, other *bool) (result *bool) {
+func OverrideWithPointer[T any](existing, other *T) (result *T) {
 	if other == nil {
 		return existing
 	}
-	result = new(bool)
+	result = new(T)
 	*result = *other
 	return result
 }
@@ -25,103 +21,20 @@ func OverrideWithString(existing, other string) (result string) {
 	return other
 }
 
-func OverrideWithInt(existing, other int) (result int) {
+func OverrideWithNumber[T Number](existing, other T) (result T) { //nolint:ireturn
 	if other == 0 {
 		return existing
 	}
 	return other
 }
 
-func OverrideWithFloat64(existing, other float64) (result float64) {
-	if other == 0 {
-		return existing
-	}
-	return other
-}
-
-func OverrideWithStringPtr(existing, other *string) (result *string) {
-	if other == nil {
-		return existing
-	}
-	result = new(string)
-	*result = *other
-	return result
-}
-
-func OverrideWithIntPtr(existing, other *int) (result *int) {
-	if other == nil {
-		return existing
-	}
-	result = new(int)
-	*result = *other
-	return result
-}
-
-func OverrideWithUint8(existing, other *uint8) (result *uint8) {
-	if other == nil {
-		return existing
-	}
-	result = new(uint8)
-	*result = *other
-	return result
-}
-
-func OverrideWithUint16(existing, other *uint16) (result *uint16) {
-	if other == nil {
-		return existing
-	}
-	result = new(uint16)
-	*result = *other
-	return result
-}
-
-func OverrideWithUint32(existing, other *uint32) (result *uint32) {
-	if other == nil {
-		return existing
-	}
-	result = new(uint32)
-	*result = *other
-	return result
-}
-
 func OverrideWithIP(existing, other netip.Addr) (result netip.Addr) {
 	if !other.IsValid() {
 		return existing
 	}
-	result, ok := netip.AddrFromSlice(other.AsSlice())
-	if !ok {
-		panic(fmt.Sprintf("failed copying other address: %s", other))
-	}
-	return result
-}
-
-func OverrideWithDuration(existing, other time.Duration) (
-	result time.Duration) {
-	if other == 0 {
-		return existing
-	}
 	return other
 }
 
-func OverrideWithDurationPtr(existing, other *time.Duration) (
-	result *time.Duration) {
-	if other == nil {
-		return existing
-	}
-	result = new(time.Duration)
-	*result = *other
-	return result
-}
-
-func OverrideWithLogLevel(existing, other *log.Level) (result *log.Level) {
-	if other == nil {
-		return existing
-	}
-	result = new(log.Level)
-	*result = *other
-	return result
-}
-
 func OverrideWithHTTPHandler(existing, other http.Handler) (result http.Handler) {
 	if other != nil {
 		return other
@@ -129,38 +42,11 @@ func OverrideWithHTTPHandler(existing, other http.Handler) (result http.Handler)
 	return existing
 }
 
-func OverrideWithStringSlice(existing, other []string) (result []string) {
+func OverrideWithSlice[T any](existing, other []T) (result []T) {
 	if other == nil {
 		return existing
 	}
-	result = make([]string, len(other))
-	copy(result, other)
-	return result
-}
-
-func OverrideWithUint16Slice(existing, other []uint16) (result []uint16) {
-	if other == nil {
-		return existing
-	}
-	result = make([]uint16, len(other))
-	copy(result, other)
-	return result
-}
-
-func OverrideWithNetipAddressesSlice(existing, other []netip.Addr) (result []netip.Addr) {
-	if other == nil {
-		return existing
-	}
-	result = make([]netip.Addr, len(other))
-	copy(result, other)
-	return result
-}
-
-func OverrideWithNetipPrefixesSlice(existing, other []netip.Prefix) (result []netip.Prefix) {
-	if other == nil {
-		return existing
-	}
-	result = make([]netip.Prefix, len(other))
+	result = make([]T, len(other))
 	copy(result, other)
 	return result
 }