Fix: Only log subproc error when it's not nil

internal/dns/loop.go

@@ -70,7 +70,9 @@ func NewLooper(conf unbound.Configurator, settings settings.DNS, client *http.Cl
 }
 
 func (l *looper) logAndWait(ctx context.Context, err error) {
-	l.logger.Warn(err)
+	if err != nil {
+		l.logger.Warn(err)
+	}
 	l.logger.Info("attempting restart in %s", l.backoffTime)
 	timer := time.NewTimer(l.backoffTime)
 	l.backoffTime *= 2

internal/openvpn/loop.go

@@ -214,7 +214,9 @@ func (l *looper) Run(ctx context.Context, wg *sync.WaitGroup) {
 }
 
 func (l *looper) logAndWait(ctx context.Context, err error) {
-	l.logger.Error(err)
+	if err != nil {
+		l.logger.Error(err)
+	}
 	l.logger.Info("retrying in %s", l.backoffTime)
 	timer := time.NewTimer(l.backoffTime)
 	l.backoffTime *= 2

internal/publicip/loop.go

@@ -74,7 +74,9 @@ func NewLooper(client *http.Client, logger logging.Logger,
 }
 
 func (l *looper) logAndWait(ctx context.Context, err error) {
-	l.logger.Error(err)
+	if err != nil {
+		l.logger.Error(err)
+	}
 	l.logger.Info("retrying in %s", l.backoffTime)
 	timer := time.NewTimer(l.backoffTime)
 	l.backoffTime *= 2

internal/shadowsocks/loop.go

@@ -34,7 +34,9 @@ type looper struct {
 }
 
 func (l *looper) logAndWait(ctx context.Context, err error) {
-	l.logger.Error(err)
+	if err != nil {
+		l.logger.Error(err)
+	}
 	l.logger.Info("retrying in %s", l.backoffTime)
 	timer := time.NewTimer(l.backoffTime)
 	l.backoffTime *= 2

internal/updater/loop.go

@@ -69,7 +69,9 @@ func NewLooper(settings settings.Updater, currentServers models.AllServers,
 }
 
 func (l *looper) logAndWait(ctx context.Context, err error) {
-	l.logger.Error(err)
+	if err != nil {
+		l.logger.Error(err)
+	}
 	l.logger.Info("retrying in %s", l.backoffTime)
 	timer := time.NewTimer(l.backoffTime)
 	l.backoffTime *= 2