chore(all): return concrete types, accept interfaces

- Remove exported interfaces unused locally
- Define interfaces to accept arguments
- Return concrete types, not interfaces
This commit is contained in:
Quentin McGaw
2022-06-11 01:34:30 +00:00
parent 0378fe4a7b
commit 578ef768ab
132 changed files with 594 additions and 935 deletions

View File

@@ -8,26 +8,12 @@ import (
"github.com/qdm12/gluetun/internal/constants"
)
type SettingsGetSetter interface {
SettingsGetter
SettingsSetter
}
type SettingsGetter interface {
GetSettings() (settings settings.HTTPProxy)
}
func (s *State) GetSettings() (settings settings.HTTPProxy) {
s.settingsMu.RLock()
defer s.settingsMu.RUnlock()
return s.settings
}
type SettingsSetter interface {
SetSettings(ctx context.Context,
settings settings.HTTPProxy) (outcome string)
}
func (s *State) SetSettings(ctx context.Context,
settings settings.HTTPProxy) (outcome string) {
s.settingsMu.Lock()