admin/gluetun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(all): return concrete types, accept interfaces

Browse Source 
- Remove exported interfaces unused locally
- Define interfaces to accept arguments
- Return concrete types, not interfaces
This commit is contained in:
Quentin McGaw
2022-06-11 01:34:30 +00:00
parent 0378fe4a7b
commit 578ef768ab
132 changed files with 594 additions and 935 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/provider/ivpn/updater/servers_test.go
View File

@@ -25,7 +25,7 @@ func Test_Updater_GetServers(t *testing.T) {
minServers int
// Mocks
warnerBuilder func(ctrl *gomock.Controller) Warner
warnerBuilder func(ctrl *gomock.Controller) common.Warner
// From API
responseBody string
@@ -43,12 +43,12 @@ func Test_Updater_GetServers(t *testing.T) {
err error
}{
"http response error": {
warnerBuilder: func(ctrl *gomock.Controller) Warner { return nil },
warnerBuilder: func(ctrl *gomock.Controller) common.Warner { return nil },
responseStatus: http.StatusNoContent,
err: errors.New("failed fetching API: HTTP status code not OK: 204 No Content"),
},
"resolve error": {
warnerBuilder: func(ctrl *gomock.Controller) Warner {
warnerBuilder: func(ctrl *gomock.Controller) common.Warner {
warner := NewMockWarner(ctrl)
warner.EXPECT().Warn("resolve warning")
return warner
@@ -65,7 +65,7 @@ func Test_Updater_GetServers(t *testing.T) {
},
"not enough servers": {
minServers: 2,
warnerBuilder: func(ctrl *gomock.Controller) Warner { return nil },
warnerBuilder: func(ctrl *gomock.Controller) common.Warner { return nil },
responseBody: `{"servers":[
{"hostnames":{"openvpn":"hosta"}}
]}`,
@@ -74,7 +74,7 @@ func Test_Updater_GetServers(t *testing.T) {
},
"success": {
minServers: 1,
warnerBuilder: func(ctrl *gomock.Controller) Warner {
warnerBuilder: func(ctrl *gomock.Controller) common.Warner {
warner := NewMockWarner(ctrl)
warner.EXPECT().Warn("resolve warning")
return warner