chore(all): return concrete types, accept interfaces

- Remove exported interfaces unused locally
- Define interfaces to accept arguments
- Return concrete types, not interfaces

internal/provider/surfshark/updater/updater.go

@@ -4,22 +4,17 @@ import (
 	"net/http"
 
 	"github.com/qdm12/gluetun/internal/provider/common"
-	"github.com/qdm12/gluetun/internal/updater/unzip"
 )
 
 type Updater struct {
 	client    *http.Client
-	unzipper  unzip.Unzipper
+	unzipper  common.Unzipper
 	presolver common.ParallelResolver
-	warner    Warner
+	warner    common.Warner
 }
 
-type Warner interface {
-	Warn(s string)
-}
-
-func New(client *http.Client, unzipper unzip.Unzipper,
-	warner Warner) *Updater {
+func New(client *http.Client, unzipper common.Unzipper,
+	warner common.Warner) *Updater {
 	return &Updater{
 		client:    client,
 		unzipper:  unzipper,

internal/provider/surfshark/updater/zip.go

@@ -4,13 +4,13 @@ import (
 	"context"
 	"strings"
 
+	"github.com/qdm12/gluetun/internal/provider/common"
 	"github.com/qdm12/gluetun/internal/provider/surfshark/servers"
 	"github.com/qdm12/gluetun/internal/updater/openvpn"
-	"github.com/qdm12/gluetun/internal/updater/unzip"
 )
 
 func addOpenVPNServersFromZip(ctx context.Context,
-	unzipper unzip.Unzipper, hts hostToServer) (
+	unzipper common.Unzipper, hts hostToServer) (
 	warnings []string, err error) {
 	const url = "https://my.surfshark.com/vpn/api/v1/server/configurations"
 	contents, err := unzipper.FetchAndExtract(ctx, url)