Golangcilint in build pipeline and fix lint errors

- Fix bad permissions bits for files
- VPNSP is 'private internet access' instead of 'pia' (retro compatible)
- Check errors of deferred unsetEnv functions in params package
-  Other lint errors fixing and code simplifications
This commit is contained in:
Quentin McGaw
2020-04-12 20:05:28 +00:00
parent 8f6b6306d6
commit 768147095f
43 changed files with 2742 additions and 2598 deletions

View File

@@ -16,7 +16,7 @@ import (
"github.com/qdm12/private-internet-access-docker/internal/constants"
)
func Test_DownloadRootHints(t *testing.T) {
func Test_DownloadRootHints(t *testing.T) { //nolint:dupl
t.Parallel()
tests := map[string]struct {
content []byte
@@ -78,7 +78,7 @@ func Test_DownloadRootHints(t *testing.T) {
}
}
func Test_DownloadRootKey(t *testing.T) {
func Test_DownloadRootKey(t *testing.T) { //nolint:dupl
t.Parallel()
tests := map[string]struct {
content []byte