Golangcilint in build pipeline and fix lint errors

- Fix bad permissions bits for files
- VPNSP is 'private internet access' instead of 'pia' (retro compatible)
- Check errors of deferred unsetEnv functions in params package
-  Other lint errors fixing and code simplifications
This commit is contained in:
Quentin McGaw
2020-04-12 20:05:28 +00:00
parent 8f6b6306d6
commit 768147095f
43 changed files with 2742 additions and 2598 deletions

View File

@@ -17,20 +17,20 @@ type System struct {
}
// GetSystemSettings obtains the System settings using the params functions
func GetSystemSettings(params params.ParamsReader) (settings System, err error) {
settings.UID, err = params.GetUID()
func GetSystemSettings(paramsReader params.Reader) (settings System, err error) {
settings.UID, err = paramsReader.GetUID()
if err != nil {
return settings, err
}
settings.GID, err = params.GetGID()
settings.GID, err = paramsReader.GetGID()
if err != nil {
return settings, err
}
settings.Timezone, err = params.GetTimezone()
settings.Timezone, err = paramsReader.GetTimezone()
if err != nil {
return settings, err
}
settings.IPStatusFilepath, err = params.GetIPStatusFilepath()
settings.IPStatusFilepath, err = paramsReader.GetIPStatusFilepath()
if err != nil {
return settings, err
}