From 7872ab91dc786791aafb5fb545f946ba84b231cc Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Sat, 18 May 2024 12:00:57 +0000 Subject: [PATCH] chore(pia): return an error to pf loop if server cannot port forward --- internal/provider/common/portforward.go | 7 +++++++ internal/provider/privateinternetaccess/portforward.go | 3 +-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 internal/provider/common/portforward.go diff --git a/internal/provider/common/portforward.go b/internal/provider/common/portforward.go new file mode 100644 index 00000000..5444b4a5 --- /dev/null +++ b/internal/provider/common/portforward.go @@ -0,0 +1,7 @@ +package common + +import "errors" + +var ( + ErrPortForwardNotSupported = errors.New("port forwarding not supported") +) diff --git a/internal/provider/privateinternetaccess/portforward.go b/internal/provider/privateinternetaccess/portforward.go index fefc6eb6..a517356c 100644 --- a/internal/provider/privateinternetaccess/portforward.go +++ b/internal/provider/privateinternetaccess/portforward.go @@ -39,8 +39,7 @@ func (p *Provider) PortForward(ctx context.Context, logger := objects.Logger if !objects.CanPortForward { - logger.Error("The server " + serverName + " does not support port forwarding") - return 0, nil + return 0, fmt.Errorf("%w: for server %s", ErrServerNameNotFound, serverName) } privateIPClient, err := newHTTPClient(serverName)