chore(settings): refactor settings processing (#756)

- Better settings tree structure logged using `qdm12/gotree`
- Read settings from environment variables, then files, then secret files
- Settings methods to default them, merge them and override them
- `DNS_PLAINTEXT_ADDRESS` default changed to `127.0.0.1` to use DoT. Warning added if set to something else.
- `HTTPPROXY_LISTENING_ADDRESS` instead of `HTTPPROXY_PORT` (with retro-compatibility)

internal/provider/nordvpn/connection.go

@@ -1,17 +1,17 @@
 package nordvpn
 
 import (
-	"github.com/qdm12/gluetun/internal/configuration"
+	"github.com/qdm12/gluetun/internal/configuration/settings"
 	"github.com/qdm12/gluetun/internal/constants"
 	"github.com/qdm12/gluetun/internal/models"
 	"github.com/qdm12/gluetun/internal/provider/utils"
 )
 
-func (n *Nordvpn) GetConnection(selection configuration.ServerSelection) (
+func (n *Nordvpn) GetConnection(selection settings.ServerSelection) (
 	connection models.Connection, err error) {
 	var port uint16 = 1194
 	protocol := constants.UDP
-	if selection.OpenVPN.TCP {
+	if *selection.OpenVPN.TCP {
 		port = 443
 		protocol = constants.TCP
 	}

internal/provider/nordvpn/filter.go

@@ -3,12 +3,12 @@ package nordvpn
 import (
 	"strconv"
 
-	"github.com/qdm12/gluetun/internal/configuration"
+	"github.com/qdm12/gluetun/internal/configuration/settings"
 	"github.com/qdm12/gluetun/internal/models"
 	"github.com/qdm12/gluetun/internal/provider/utils"
 )
 
-func (n *Nordvpn) filterServers(selection configuration.ServerSelection) (
+func (n *Nordvpn) filterServers(selection settings.ServerSelection) (
 	servers []models.NordvpnServer, err error) {
 	selectedNumbers := make([]string, len(selection.Numbers))
 	for i := range selection.Numbers {

internal/provider/nordvpn/openvpnconf.go

@@ -3,24 +3,26 @@ package nordvpn
 import (
 	"strconv"
 
-	"github.com/qdm12/gluetun/internal/configuration"
+	"github.com/qdm12/gluetun/internal/configuration/settings"
 	"github.com/qdm12/gluetun/internal/constants"
 	"github.com/qdm12/gluetun/internal/models"
 	"github.com/qdm12/gluetun/internal/provider/utils"
 )
 
 func (n *Nordvpn) BuildConf(connection models.Connection,
-	settings configuration.OpenVPN) (lines []string, err error) {
+	settings settings.OpenVPN) (lines []string, err error) {
 	if len(settings.Ciphers) == 0 {
 		settings.Ciphers = []string{constants.AES256cbc}
 	}
 
-	if settings.Auth == "" {
-		settings.Auth = constants.SHA512
+	auth := *settings.Auth
+	if auth == "" {
+		auth = constants.SHA512
 	}
 
-	if settings.MSSFix == 0 {
-		settings.MSSFix = 1450
+	mssFix := *settings.MSSFix
+	if mssFix == 0 {
+		mssFix = 1450
 	}
 
 	lines = []string{
@@ -28,17 +30,17 @@ func (n *Nordvpn) BuildConf(connection models.Connection,
 		"nobind",
 		"tls-exit",
 		"dev " + settings.Interface,
-		"verb " + strconv.Itoa(settings.Verbosity),
+		"verb " + strconv.Itoa(*settings.Verbosity),
 
 		// Nordvpn specific
 		"tun-mtu-extra 32",
-		"mssfix " + strconv.Itoa(int(settings.MSSFix)),
+		"mssfix " + strconv.Itoa(int(mssFix)),
 		"ping 15",
 		"remote-cert-tls server",
 		"reneg-sec 0",
 		"key-direction 1",
 		"auth-user-pass " + constants.OpenVPNAuthConf,
-		"auth " + settings.Auth,
+		"auth " + auth,
 		"comp-lzo", // Required, NordVPN does not work without it
 
 		// Added constant values
@@ -60,13 +62,13 @@ func (n *Nordvpn) BuildConf(connection models.Connection,
 		lines = append(lines, "explicit-exit-notify")
 	}
 
-	if !settings.Root {
+	if !*settings.Root {
 		lines = append(lines, "user "+settings.ProcUser)
 		lines = append(lines, "persist-tun")
 		lines = append(lines, "persist-key")
 	}
 
-	if !settings.IPv6 {
+	if !*settings.IPv6 {
 		lines = append(lines, `pull-filter ignore "route-ipv6"`)
 		lines = append(lines, `pull-filter ignore "ifconfig-ipv6"`)
 	}