chore(internal/providers): simplify OpenVPN config building

internal/provider/vpnunlimited/openvpnconf.go

@@ -1,86 +1,23 @@
 package vpnunlimited
 
 import (
-	"fmt"
-	"strconv"
-
 	"github.com/qdm12/gluetun/internal/configuration/settings"
 	"github.com/qdm12/gluetun/internal/constants"
 	"github.com/qdm12/gluetun/internal/models"
-	"github.com/qdm12/gluetun/internal/openvpn/parse"
 	"github.com/qdm12/gluetun/internal/provider/utils"
 )
 
 func (p *Provider) BuildConf(connection models.Connection,
-	settings settings.OpenVPN) (lines []string, err error) {
-	lines = []string{
-		"client",
-		"nobind",
-		"tls-exit",
-		"dev " + settings.Interface,
-		"verb " + strconv.Itoa(*settings.Verbosity),
-
-		// VPNUnlimited specific
-		"ping 5",
-		"remote-cert-tls server",
-		"reneg-sec 0",
-		"route-metric 1",
-
-		// Added constant values
-		"auth-nocache",
-		"mute-replay-warnings",
-		"pull-filter ignore \"auth-token\"", // prevent auth failed loops
-		"auth-retry nointeract",
-		"suppress-timestamps",
-
-		// Connection variables
-		connection.OpenVPNProtoLine(),
-		connection.OpenVPNRemoteLine(),
+	settings settings.OpenVPN) (lines []string) {
+	providerSettings := utils.OpenVPNProviderSettings{
+		RemoteCertTLS: true,
+		AuthUserPass:  false,
+		Ping:          5, //nolint:gomnd
+		RenegDisabled: true,
+		CA:            constants.VPNUnlimitedCA,
+		ExtraLines: []string{
+			"route-metric 1",
+		},
 	}
-
-	if len(settings.Ciphers) > 0 {
-		lines = append(lines, utils.CipherLines(settings.Ciphers, settings.Version)...)
-	}
-
-	if *settings.Auth != "" {
-		lines = append(lines, "auth "+*settings.Auth)
-	}
-
-	if *settings.MSSFix > 0 {
-		lines = append(lines, "mssfix "+strconv.Itoa(int(*settings.MSSFix)))
-	}
-
-	if connection.Protocol == constants.UDP {
-		lines = append(lines, "explicit-exit-notify")
-	}
-
-	if settings.ProcessUser != "root" {
-		lines = append(lines, "user "+settings.ProcessUser)
-		lines = append(lines, "persist-tun")
-		lines = append(lines, "persist-key")
-	}
-
-	if !*settings.IPv6 {
-		lines = append(lines, `pull-filter ignore "route-ipv6"`)
-		lines = append(lines, `pull-filter ignore "ifconfig-ipv6"`)
-	}
-
-	lines = append(lines, utils.WrapOpenvpnCA(
-		constants.VPNUnlimitedCA)...)
-
-	certData, err := parse.ExtractCert([]byte(*settings.ClientCrt))
-	if err != nil {
-		return nil, fmt.Errorf("client cert is not valid: %w", err)
-	}
-	lines = append(lines, utils.WrapOpenvpnCert(certData)...)
-
-	keyData, err := parse.ExtractPrivateKey([]byte(*settings.ClientKey))
-	if err != nil {
-		return nil, fmt.Errorf("client key is not valid: %w", err)
-	}
-	lines = append(lines, utils.WrapOpenvpnKey(keyData)...)
-
-	lines = append(lines, "")
-
-	return lines, nil
+	return utils.OpenVPNConfig(providerSettings, connection, settings)
 }