chore(lint): add new linters and update codebase

- add canonicalheader
- add copyloopvar
- add fatcontext
- add intrange
This commit is contained in:
Quentin McGaw
2024-10-11 18:28:00 +00:00
parent 3c8e80a1a4
commit abe9dcbe33
77 changed files with 8 additions and 116 deletions

View File

@@ -27,7 +27,7 @@ func (a *apiKeyMethod) equal(other authorizationChecker) bool {
}
func (a *apiKeyMethod) isAuthorized(_ http.Header, request *http.Request) bool {
xAPIKey := request.Header.Get("X-API-Key")
xAPIKey := request.Header.Get("X-API-Key") //nolint:canonicalheader
if xAPIKey == "" {
xAPIKey = request.URL.Query().Get("api_key")
}

View File

@@ -57,7 +57,6 @@ routes = ["GET /v1/vpn/status"]
}
for name, testCase := range testCases {
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

View File

@@ -44,7 +44,6 @@ func Test_settingsToLookupMap(t *testing.T) {
}
for name, testCase := range testCases {
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

View File

@@ -80,7 +80,6 @@ func Test_authHandler_ServeHTTP(t *testing.T) {
}
for name, testCase := range testCases {
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()
ctrl := gomock.NewController(t)