From b0bd06bdc5b5e0fbf702203b7b9caf4ac64fe9db Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Tue, 9 Feb 2021 02:45:50 +0000 Subject: [PATCH] Feature: only log health when health state changes --- internal/healthcheck/handler.go | 1 - internal/healthcheck/health.go | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/healthcheck/handler.go b/internal/healthcheck/handler.go index f8b31bfc..ffa0d535 100644 --- a/internal/healthcheck/handler.go +++ b/internal/healthcheck/handler.go @@ -29,7 +29,6 @@ func (h *handler) ServeHTTP(responseWriter http.ResponseWriter, request *http.Re return } if err := h.getErr(); err != nil { - h.logger.Error(err) http.Error(responseWriter, err.Error(), http.StatusInternalServerError) return } diff --git a/internal/healthcheck/health.go b/internal/healthcheck/health.go index 0e5e6373..4cb90bfa 100644 --- a/internal/healthcheck/health.go +++ b/internal/healthcheck/health.go @@ -19,7 +19,9 @@ func (s *server) runHealthcheckLoop(ctx context.Context, wg *sync.WaitGroup) { s.handler.setErr(err) if previousErr != nil && err == nil { - s.logger.Info("passed") + s.logger.Info("healthy!") + } else if previousErr == nil && err != nil { + s.logger.Info("unhealthy: " + err.Error()) } if err != nil { // try again after 1 second