Maintenance: Fix exit race condition

This commit is contained in:
Quentin McGaw
2021-01-26 01:04:15 +00:00
parent a243d48fb1
commit b1ff95affa
2 changed files with 6 additions and 3 deletions

View File

@@ -110,6 +110,9 @@ func (l *looper) Run(ctx context.Context, wg *sync.WaitGroup, dnsReadyCh chan<-
for l.GetSettings().Enabled { for l.GetSettings().Enabled {
if ctx.Err() != nil { if ctx.Err() != nil {
if !crashed {
l.running <- constants.Stopped
}
l.logger.Warn("context canceled: exiting loop") l.logger.Warn("context canceled: exiting loop")
return return
} }

View File

@@ -39,12 +39,11 @@ func New(address string, logging bool, logger logging.Logger,
} }
func (s *server) Run(ctx context.Context, wg *sync.WaitGroup) { func (s *server) Run(ctx context.Context, wg *sync.WaitGroup) {
defer wg.Done()
server := http.Server{Addr: s.address, Handler: s.handler} server := http.Server{Addr: s.address, Handler: s.handler}
go func() { go func() {
defer wg.Done()
<-ctx.Done() <-ctx.Done()
s.logger.Warn("context canceled: exiting loop") s.logger.Warn("context canceled: shutting down")
defer s.logger.Warn("loop exited")
const shutdownGraceDuration = 2 * time.Second const shutdownGraceDuration = 2 * time.Second
shutdownCtx, cancel := context.WithTimeout(context.Background(), shutdownGraceDuration) shutdownCtx, cancel := context.WithTimeout(context.Background(), shutdownGraceDuration)
defer cancel() defer cancel()
@@ -57,4 +56,5 @@ func (s *server) Run(ctx context.Context, wg *sync.WaitGroup) {
if err != nil && ctx.Err() != context.Canceled { if err != nil && ctx.Err() != context.Canceled {
s.logger.Error(err) s.logger.Error(err)
} }
s.logger.Warn("shut down")
} }