Maint: common GetProtocol for OpenVPN+Wireguard providers

internal/provider/ivpn/connection.go

@@ -10,7 +10,7 @@ import (
 func (i *Ivpn) GetConnection(selection configuration.ServerSelection) (
 	connection models.Connection, err error) {
 	port := getPort(selection)
-	protocol := getProtocol(selection)
+	protocol := utils.GetProtocol(selection)
 
 	servers, err := i.filterServers(selection)
 	if err != nil {
@@ -60,10 +60,3 @@ func getPort(selection configuration.ServerSelection) (port uint16) {
 		return port
 	}
 }
-
-func getProtocol(selection configuration.ServerSelection) (protocol string) {
-	if selection.VPN == constants.OpenVPN && selection.OpenVPN.TCP {
-		return constants.TCP
-	}
-	return constants.UDP
-}

internal/provider/ivpn/connection_test.go

@@ -158,42 +158,3 @@ func Test_getPort(t *testing.T) {
 		})
 	}
 }
-
-func Test_getProtocol(t *testing.T) {
-	t.Parallel()
-
-	testCases := map[string]struct {
-		selection configuration.ServerSelection
-		protocol  string
-	}{
-		"OpenVPN UDP": {
-			protocol: constants.UDP,
-		},
-		"OpenVPN TCP": {
-			selection: configuration.ServerSelection{
-				VPN: constants.OpenVPN,
-				OpenVPN: configuration.OpenVPNSelection{
-					TCP: true,
-				},
-			},
-			protocol: constants.TCP,
-		},
-		"Wireguard": {
-			selection: configuration.ServerSelection{
-				VPN: constants.Wireguard,
-			},
-			protocol: constants.UDP,
-		},
-	}
-
-	for name, testCase := range testCases {
-		testCase := testCase
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
-			protocol := getProtocol(testCase.selection)
-
-			assert.Equal(t, testCase.protocol, protocol)
-		})
-	}
-}