From e583f9de47b2b1a2496fe3e47f1b231c77cc5916 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Sat, 27 Aug 2022 16:45:29 +0000 Subject: [PATCH] fix(codeql): fix integer parsing (false positive) --- internal/configuration/sources/env/serverselection.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/configuration/sources/env/serverselection.go b/internal/configuration/sources/env/serverselection.go index 6c1473d5..a70708b1 100644 --- a/internal/configuration/sources/env/serverselection.go +++ b/internal/configuration/sources/env/serverselection.go @@ -52,7 +52,8 @@ func (s *Source) readServerSelection(vpnProvider, vpnType string) ( numbersStrings := strings.Split(csv, ",") numbers := make([]uint16, len(numbersStrings)) for i, numberString := range numbersStrings { - number, err := strconv.Atoi(numberString) + const base, bitSize = 10, 16 + number, err := strconv.ParseInt(numberString, base, bitSize) if err != nil { return ss, fmt.Errorf("%w: %s", ErrServerNumberNotValid, numberString)