admin/gluetun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(codeql): fix integer parsing (false positive)

Browse Source
This commit is contained in:
Quentin McGaw
2022-08-27 16:45:29 +00:00
parent 8570e09eb9
commit e583f9de47
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/configuration/sources/env/serverselection.go vendored
View File

@@ -52,7 +52,8 @@ func (s *Source) readServerSelection(vpnProvider, vpnType string) (
numbersStrings := strings.Split(csv, ",") numbersStrings := strings.Split(csv, ",")
numbers := make([]uint16, len(numbersStrings)) numbers := make([]uint16, len(numbersStrings))
for i, numberString := range numbersStrings { for i, numberString := range numbersStrings {
number, err := strconv.Atoi(numberString) const base, bitSize = 10, 16
number, err := strconv.ParseInt(numberString, base, bitSize)
if err != nil { if err != nil {
return ss, fmt.Errorf("%w: %s", return ss, fmt.Errorf("%w: %s",
ErrServerNumberNotValid, numberString) ErrServerNumberNotValid, numberString)