library: fmt.(*pp).doPrint; syscall.forkAndExecInChild

_cmptest/osexec/exec.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"fmt"
 	"os"
 	"os/exec"
 	"runtime"
@@ -15,4 +16,7 @@ func main() {
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	cmd.Run()
+
+	output, _ := exec.Command(ls).Output()
+	fmt.Print(string(output))
 }

internal/lib/fmt/print.go

@@ -1218,7 +1218,6 @@ formatLoop:
 }
 
 func (p *pp) doPrint(a []any) {
-	/*
 	prevString := false
 	for argNum, arg := range a {
 		isString := arg != nil && reflect.TypeOf(arg).Kind() == reflect.String
@@ -1229,8 +1228,6 @@ func (p *pp) doPrint(a []any) {
 		p.printArg(arg, 'v')
 		prevString = isString
 	}
-	*/
-	panic("todo: fmt.(*pp).doPrint")
 }
 
 // doPrintln is like doPrint but always adds a space between arguments

internal/lib/syscall/exec_libc2.go

@@ -7,6 +7,8 @@
 package syscall
 
 import (
+	"unsafe"
+
 	"github.com/goplus/llgo/c"
 	"github.com/goplus/llgo/c/os"
 	"github.com/goplus/llgo/c/syscall"
@@ -322,12 +324,9 @@ func forkAndExecInChild(argv0 *c.Char, argv, envv **c.Char, chroot, dir *c.Char,
 	*/
 
 childerror:
-	/* TODO(xsw):
 	// send error code on pipe
-	rawSyscall(abi.FuncPCABI0(libc_write_trampoline), uintptr(pipe), uintptr(unsafe.Pointer(&err1)), unsafe.Sizeof(err1))
+	os.Write(c.Int(pipe), unsafe.Pointer(&err1), unsafe.Sizeof(err1))
 	for {
-		rawSyscall(abi.FuncPCABI0(libc_exit_trampoline), 253, 0, 0)
+		os.Exit(253)
 	}
-	*/
-	panic("todo: syscall.forkAndExecInChild - childerror")
 }