From 5c8e715fc6331054e204502204ac5030fa476a72 Mon Sep 17 00:00:00 2001
From: Sandeep Singh <sandeep@projectdiscovery.io>
Date: Mon, 5 Dec 2022 18:22:55 +0530
Subject: [PATCH] workflows improvements (#2963)

---
 .github/workflows/build-test.yml        | 9 +++++++--
 .github/workflows/dockerhub-push.yml    | 4 ++--
 .github/workflows/functional-test.yml   | 2 ++
 .github/workflows/publish-docs.yaml     | 8 +++++---
 .github/workflows/sonarcloud.yml        | 3 ++-
 .github/workflows/template-validate.yml | 2 ++
 6 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
index 4bdbd5bf5..2e5270241 100644
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -2,6 +2,8 @@ name: 🔨 Build Test
 
 on:
   pull_request:
+    paths:
+      - '**.go'
   workflow_dispatch:
 
 jobs:
@@ -11,6 +13,7 @@ jobs:
       matrix:
         go-version: [1.18.x, 1.19.x]
         os: [ubuntu-latest, windows-latest, macOS-12]
+
     runs-on: ${{ matrix.os }}
     steps:
       - name: Set up Go
@@ -21,8 +24,10 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v3
 
-      - name: Download modules
-        run: go clean -modcache; go mod download
+      - name: Go Mod hygine
+        run: |
+          go clean -modcache
+          go mod tidy
         working-directory: v2/
 
       - name: Build
diff --git a/.github/workflows/dockerhub-push.yml b/.github/workflows/dockerhub-push.yml
index 43b29c737..d7686d511 100644
--- a/.github/workflows/dockerhub-push.yml
+++ b/.github/workflows/dockerhub-push.yml
@@ -17,7 +17,7 @@ jobs:
       - name: Get Github tag
         id: meta
         run: |
-          echo "::set-output name=tag::$(curl --silent "https://api.github.com/repos/projectdiscovery/nuclei/releases/latest" | jq -r .tag_name)"
+          curl --silent "https://api.github.com/repos/projectdiscovery/nuclei/releases/latest" | jq -r .tag_name | xargs -I {} echo TAG={} >> $GITHUB_OUTPUT
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
@@ -37,4 +37,4 @@ jobs:
           context: .
           platforms: linux/amd64,linux/arm64
           push: true
-          tags: projectdiscovery/nuclei:latest,projectdiscovery/nuclei:${{ steps.meta.outputs.tag }}
\ No newline at end of file
+          tags: projectdiscovery/nuclei:latest,projectdiscovery/nuclei:${{ steps.meta.outputs.TAG }}
\ No newline at end of file
diff --git a/.github/workflows/functional-test.yml b/.github/workflows/functional-test.yml
index c54d36515..66e9dd60f 100644
--- a/.github/workflows/functional-test.yml
+++ b/.github/workflows/functional-test.yml
@@ -2,6 +2,8 @@ name: 🧪 Functional Test
 
 on:
   pull_request:
+    paths:
+      - '**.go'
   workflow_dispatch:
 
 
diff --git a/.github/workflows/publish-docs.yaml b/.github/workflows/publish-docs.yaml
index 425de8e2d..b3967bd6b 100644
--- a/.github/workflows/publish-docs.yaml
+++ b/.github/workflows/publish-docs.yaml
@@ -2,6 +2,8 @@ name: ⏰ Publish Docs
 
 on:
   pull_request:
+    paths:
+      - '**.go'
   workflow_dispatch:
 
 jobs:
@@ -30,11 +32,11 @@ jobs:
           go generate pkg/templates/templates.go
           go build -o "cmd/docgen/docgen" cmd/docgen/docgen.go 
           ./cmd/docgen/docgen ../SYNTAX-REFERENCE.md ../nuclei-jsonschema.json
-          echo "::set-output name=changes::$(git status -s | wc -l)"
+          git status -s | wc -l | xargs -I {} echo CHANGES={} >> $GITHUB_OUTPUT
         working-directory: v2
 
       - name: Commit files
-        if: steps.generate-docs.outputs.changes > 0
+        if: steps.generate-docs.outputs.CHANGES > 0
         run: |
           git config --local user.email "action@github.com"
           git config --local user.name "GitHub Action"
@@ -42,7 +44,7 @@ jobs:
           git commit -m "Auto Generate Syntax Docs + JSONSchema [$(date)] :robot:" -a
 
       - name: Push changes
-        if: steps.generate-docs.outputs.changes > 0
+        if: steps.generate-docs.outputs.CHANGES > 0
         uses: ad-m/github-push-action@master
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
index c084d69fa..99c6772a2 100644
--- a/.github/workflows/sonarcloud.yml
+++ b/.github/workflows/sonarcloud.yml
@@ -2,7 +2,8 @@ name: 👮🏼‍♂️ Sonarcloud
 
 on:
   pull_request:
-    types: [opened, synchronize, reopened]
+    paths:
+      - '**.go'
   workflow_dispatch:
 
 jobs:
diff --git a/.github/workflows/template-validate.yml b/.github/workflows/template-validate.yml
index 7b00e240f..2fc10b97d 100644
--- a/.github/workflows/template-validate.yml
+++ b/.github/workflows/template-validate.yml
@@ -2,6 +2,8 @@ name: 🛠 Template Validate
 
 on:
   pull_request:
+    paths:
+      - '**.go'
   workflow_dispatch:
 
 jobs: