2024-10-22 09:20:57 -07:00
using Bit.Core.Settings ;
using Bit.Core.Utilities ;
using Microsoft.Azure.NotificationHubs ;
using Microsoft.Extensions.Logging ;
namespace Bit.Core.NotificationHub ;
public class NotificationHubPool : INotificationHubPool
{
private List < NotificationHubConnection > _connections { get ; }
private readonly IEnumerable < INotificationHubClient > _clients ;
private readonly ILogger < NotificationHubPool > _logger ;
public NotificationHubPool ( ILogger < NotificationHubPool > logger , GlobalSettings globalSettings )
{
_logger = logger ;
_connections = FilterInvalidHubs ( globalSettings . NotificationHubPool . NotificationHubs ) ;
_clients = _connections . GroupBy ( c = > c . ConnectionString ) . Select ( g = > g . First ( ) . HubClient ) ;
}
private List < NotificationHubConnection > FilterInvalidHubs ( IEnumerable < GlobalSettings . NotificationHubSettings > hubs )
{
List < NotificationHubConnection > result = new ( ) ;
_logger . LogDebug ( "Filtering {HubCount} notification hubs" , hubs . Count ( ) ) ;
foreach ( var hub in hubs )
{
var connection = NotificationHubConnection . From ( hub ) ;
if ( ! connection . IsValid )
{
_logger . LogWarning ( "Invalid notification hub settings: {HubName}" , hub . HubName ? ? "hub name missing" ) ;
continue ;
}
_logger . LogDebug ( "Adding notification hub: {ConnectionLogString}" , connection . LogString ) ;
result . Add ( connection ) ;
}
return result ;
}
/// <summary>
/// Gets the NotificationHubClient for the given comb ID.
/// </summary>
/// <param name="comb"></param>
/// <returns></returns>
/// <exception cref="InvalidOperationException">Thrown when no notification hub is found for a given comb.</exception>
[PM-10600] Push notification creation to affected clients (#4923)
* PM-10600: Notification push notification
* PM-10600: Sending to specific client types for relay push notifications
* PM-10600: Sending to specific client types for other clients
* PM-10600: Send push notification on notification creation
* PM-10600: Explicit group names
* PM-10600: Id typos
* PM-10600: Revert global push notifications
* PM-10600: Added DeviceType claim
* PM-10600: Sent to organization typo
* PM-10600: UT coverage
* PM-10600: Small refactor, UTs coverage
* PM-10600: UTs coverage
* PM-10600: Startup fix
* PM-10600: Test fix
* PM-10600: Required attribute, organization group for push notification fix
* PM-10600: UT coverage
* PM-10600: Fix Mobile devices not registering to organization push notifications
We only register devices for organization push notifications when the organization is being created. This does not work, since we have a use case (Notification Center) of delivering notifications to all users of organization. This fixes it, by adding the organization id tag when device registers for push notifications.
* PM-10600: Unit Test coverage for NotificationHubPushRegistrationService
Fixed IFeatureService substitute mocking for Android tests.
Added user part of organization test with organizationId tags expectation.
* PM-10600: Unit Tests fix to NotificationHubPushRegistrationService after merge conflict
* PM-10600: Organization push notifications not sending to mobile device from self-hosted.
Self-hosted instance uses relay to register the mobile device against Bitwarden Cloud Api. Only the self-hosted server knows client's organization membership, which means it needs to pass in the organization id's information to the relay. Similarly, for Bitwarden Cloud, the organizaton id will come directly from the server.
* PM-10600: Fix self-hosted organization notification not being received by mobile device.
When mobile device registers on self-hosted through the relay, every single id, like user id, device id and now organization id needs to be prefixed with the installation id. This have been missing in the PushController that handles this for organization id.
* PM-10600: Broken NotificationsController integration test
Device type is now part of JWT access token, so the notification center results in the integration test are now scoped to client type web and all.
* PM-10600: Merge conflicts fix
* merge conflict fix
2025-02-12 16:46:30 +01:00
public INotificationHubClient ClientFor ( Guid comb )
2024-10-22 09:20:57 -07:00
{
var possibleConnections = _connections . Where ( c = > c . RegistrationEnabled ( comb ) ) . ToArray ( ) ;
if ( possibleConnections . Length = = 0 )
{
throw new InvalidOperationException ( $"No valid notification hubs are available for the given comb ({comb}).\n" +
$"The comb's datetime is {CoreHelpers.DateFromComb(comb)}." +
$"Hub start and end times are configured as follows:\n" +
string . Join ( "\n" , _connections . Select ( c = > $"Hub {c.HubName} - Start: {c.RegistrationStartDate}, End: {c.RegistrationEndDate}" ) ) ) ;
}
var resolvedConnection = possibleConnections [ CoreHelpers . BinForComb ( comb , possibleConnections . Length ) ] ;
_logger . LogTrace ( "Resolved notification hub for comb {Comb} out of {HubCount} hubs.\n{ConnectionInfo}" , comb , possibleConnections . Length , resolvedConnection . LogString ) ;
return resolvedConnection . HubClient ;
}
public INotificationHubProxy AllClients { get { return new NotificationHubClientProxy ( _clients ) ; } }
}