admin/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2026-01-31 14:13:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Build TVP arrays outside connection

Browse Source 
SQL connections sometimes seem to time out while building these.
We can pre-build them, so we should.
This commit is contained in:
Matt Gibson
2021-10-18 13:12:30 -04:00
parent 86755e130c
commit a68e09b708
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Core/Repositories/SqlServer/OrganizationUserRepository.cs
View File

@@ -231,11 +231,12 @@ namespace Bit.Core.Repositories.SqlServer
public async Task UpdateGroupsAsync(Guid orgUserId, IEnumerable<Guid> groupIds)
{
var tvpIds = groupIds.ToGuidIdArrayTVP();
using (var connection = new SqlConnection(ConnectionString))
{
var results = await connection.ExecuteAsync(
"[dbo].[GroupUser_UpdateGroups]",
new { OrganizationUserId = orgUserId, GroupIds = groupIds.ToGuidIdArrayTVP() },
new { OrganizationUserId = orgUserId, GroupIds = tvpIds },
commandType: CommandType.StoredProcedure);
}
}
@@ -275,11 +276,12 @@ namespace Bit.Core.Repositories.SqlServer
public async Task<ICollection<OrganizationUser>> GetManyByManyUsersAsync(IEnumerable<Guid> userIds)
{
var tvpIds = userIds.ToGuidIdArrayTVP();
using (var connection = new SqlConnection(ConnectionString))
{
var results = await connection.QueryAsync<OrganizationUser>(
"[dbo].[OrganizationUser_ReadByUserIds]",
new { UserIds = userIds.ToGuidIdArrayTVP() },
new { UserIds = tvpIds },
commandType: CommandType.StoredProcedure);
return results.ToList();
@@ -288,11 +290,12 @@ namespace Bit.Core.Repositories.SqlServer
public async Task<ICollection<OrganizationUser>> GetManyAsync(IEnumerable<Guid> Ids)
{
var tvpIds = Ids.ToGuidIdArrayTVP();
using (var connection = new SqlConnection(ConnectionString))
{
var results = await connection.QueryAsync<OrganizationUser>(
"[dbo].[OrganizationUser_ReadByIds]",
new { Ids = Ids.ToGuidIdArrayTVP() },
new { Ids = tvpIds },
commandType: CommandType.StoredProcedure);
return results.ToList();
@@ -314,10 +317,11 @@ namespace Bit.Core.Repositories.SqlServer
public async Task DeleteManyAsync(IEnumerable<Guid> organizationUserIds)
{
var tvpIds = organizationUserIds.ToGuidIdArrayTVP();
using (var connection = new SqlConnection(ConnectionString))
{
await connection.ExecuteAsync("[dbo].[OrganizationUser_DeleteByIds]",
new { Ids = organizationUserIds.ToGuidIdArrayTVP() }, commandType: CommandType.StoredProcedure);
new { Ids = tvpIds }, commandType: CommandType.StoredProcedure);
}
}
@@ -385,11 +389,12 @@ namespace Bit.Core.Repositories.SqlServer
public async Task<IEnumerable<OrganizationUserPublicKey>> GetManyPublicKeysByOrganizationUserAsync(
Guid organizationId, IEnumerable<Guid> Ids)
{
var tvpIds = Ids.ToGuidIdArrayTVP();
using (var connection = new SqlConnection(ConnectionString))
{
var results = await connection.QueryAsync<OrganizationUserPublicKey>(
"[dbo].[User_ReadPublicKeysByOrganizationUserIds]",
new { OrganizationId = organizationId, OrganizationUserIds = Ids.ToGuidIdArrayTVP() },
new { OrganizationId = organizationId, OrganizationUserIds = tvpIds },
commandType: CommandType.StoredProcedure);
return results.ToList();