feat: support wildcard in ignored_containers (#666)

Cargo.lock

@@ -2417,6 +2417,7 @@ dependencies = [
  "tracing-subscriber",
  "walkdir",
  "which",
+ "wildmatch",
  "winapi",
 ]
 
@@ -2712,6 +2713,12 @@ version = "0.4.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "c168940144dd21fd8046987c16a46a33d5fc84eec29ef9dcddc2ac9e31526b7c"
 
+[[package]]
+name = "wildmatch"
+version = "2.3.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "495ec47bf3c1345005f40724f0269362c8556cbc43aed0526ed44cae1d35fceb"
+
 [[package]]
 name = "winapi"
 version = "0.3.9"

Cargo.toml

@@ -50,6 +50,7 @@ tracing-subscriber = { version = "~0.3", features = ["env-filter", "time"] }
 merge = "~0.1"
 regex-split = "~0.1"
 notify-rust = "~4.10"
+wildmatch = "2.3.0"
 
 [package.metadata.generate-rpm]
 assets = [{ source = "target/release/topgrade", dest = "/usr/bin/topgrade" }]

config.example.toml

@@ -229,4 +229,5 @@
 
 # containers = ["archlinux-latest"]
 [containers]
-# ignored_containers = ["ghcr.io/rancher-sandbox/rancher-desktop/rdx-proxy:latest"]
+# Specify the containers to ignore while updating (Wildcard supported)
+# ignored_containers = ["ghcr.io/rancher-sandbox/rancher-desktop/rdx-proxy:latest", "docker.io*"]

src/steps/containers.rs

@@ -6,6 +6,7 @@ use color_eyre::eyre::eyre;
 use color_eyre::eyre::Context;
 use color_eyre::eyre::Result;
 use tracing::{debug, error, warn};
+use wildmatch::WildMatch;
 
 use crate::command::CommandExt;
 use crate::error::{self, TopgradeError};
@@ -51,6 +52,13 @@ impl Display for Container {
 ///
 /// Containers specified in `ignored_containers` will be filtered out.
 fn list_containers(crt: &Path, ignored_containers: Option<&Vec<String>>) -> Result<Vec<Container>> {
+    let ignored_containers = ignored_containers.map(|patterns| {
+        patterns
+            .iter()
+            .map(|pattern| WildMatch::new(pattern))
+            .collect::<Vec<WildMatch>>()
+    });
+
     debug!(
         "Querying '{} image ls --format \"{{{{.Repository}}}}:{{{{.Tag}}}}/{{{{.ID}}}}\"' for containers",
         crt.display()
@@ -85,11 +93,8 @@ fn list_containers(crt: &Path, ignored_containers: Option<&Vec<String>>) -> Resu
         assert_eq!(split_res.len(), 2);
         let (repo_tag, image_id) = (split_res[0], split_res[1]);
 
-        if let Some(ignored_containers) = ignored_containers {
+        if let Some(ref ignored_containers) = ignored_containers {
-            if ignored_containers
+            if ignored_containers.iter().any(|pattern| pattern.matches(repo_tag)) {
-                .iter()
-                .any(|ignored_container| repo_tag.eq(ignored_container))
-            {
                 debug!("Skipping ignored container '{}'", line);
                 continue;
             }