admin/topgrade
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow running NPM as sudo (fix #690) (#723)

Browse Source 
* Allow running NPM as sudo (fix #690)

* asd

* fix
This commit is contained in:
Roey Darwish Dror
2021-06-09 10:52:48 +03:00
committed by GitHub
parent f8648c9bc7
commit f39899c3ff
4 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/steps/node.rs
View File

@@ -32,15 +32,25 @@ impl NPM {
.map(|s| PathBuf::from(s.trim()))
}
fn upgrade(&self, run_type: RunType) -> Result<()> {
run_type.execute(&self.command).args(&["update", "-g"]).check_run()?;
fn upgrade(&self, run_type: RunType, use_sudo: bool) -> Result<()> {
if use_sudo {
run_type
.execute("sudo")
.arg(&self.command)
.args(&["update", "-g"])
.check_run()?;
} else {
run_type.execute(&self.command).args(&["update", "-g"]).check_run()?;
}
Ok(())
}
}
pub fn run_npm_upgrade(_base_dirs: &BaseDirs, run_type: RunType) -> Result<()> {
pub fn run_npm_upgrade(ctx: &ExecutionContext) -> Result<()> {
let npm = require("npm").map(NPM::new)?;
#[allow(unused_mut)]
let mut use_sudo = false;
#[cfg(target_os = "linux")]
{
@@ -53,17 +63,21 @@ pub fn run_npm_upgrade(_base_dirs: &BaseDirs, run_type: RunType) -> Result<()> {
let uid = Uid::effective();
if metadata.uid() != uid.as_raw() {
return Err(SkipStep(format!(
"NPM root at {} is owned by {} which is not the current user",
npm_root.display(),
metadata.uid()
))
.into());
if metadata.uid() == 0 && (ctx.config().npm_use_sudo()) {
use_sudo = true;
} else {
return Err(SkipStep(format!(
"NPM root at {} is owned by {} which is not the current user. Set use_sudo = true under the NPM section in your configuration to run NPM as sudo",
npm_root.display(),
metadata.uid()
))
.into());
}
}
}
print_separator("Node Package Manager");
npm.upgrade(run_type)
npm.upgrade(ctx.run_type(), use_sudo)
}
pub fn yarn_global_update(run_type: RunType) -> Result<()> {