admin/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2026-01-31 11:03:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: add error logging to cloudflared socket handler empty catch blocks

Browse Source 
Previously, errors in cloudflared socket handlers were silently swallowed
by empty catch blocks, making debugging difficult. This commit adds
proper error logging to all empty catch blocks in the cloudflared
socket handler to improve observability and debugging.

- Added error logging to join handler
- Added error logging to leave handler
- Added error logging to start handler
- Added error logging to removeToken handler
This commit is contained in:
Angel98518
2026-01-06 19:31:25 +01:00
parent 11a2b8ed9b
commit 951f109512
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
server/socket-handlers/cloudflared-socket-handler.js
View File

@@ -41,14 +41,18 @@ module.exports.cloudflaredSocketHandler = (socket) => {
io.to(socket.userID).emit(prefix + "installed", cloudflared.checkInstalled());
io.to(socket.userID).emit(prefix + "running", cloudflared.running);
io.to(socket.userID).emit(prefix + "token", await setting("cloudflaredTunnelToken"));
} catch (error) { }
} catch (error) {
log.error("cloudflared", "Error in join handler: " + error.message);
}
});
socket.on(prefix + "leave", async () => {
try {
checkLogin(socket);
socket.leave("cloudflared");
} catch (error) { }
} catch (error) {
log.error("cloudflared", "Error in leave handler: " + error.message);
}
});
socket.on(prefix + "start", async (token) => {
@@ -61,7 +65,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
cloudflared.token = null;
}
cloudflared.start();
} catch (error) { }
} catch (error) {
log.error("cloudflared", "Error in start handler: " + error.message);
}
});
socket.on(prefix + "stop", async (currentPassword, callback) => {
@@ -84,7 +90,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
try {
checkLogin(socket);
await setSetting("cloudflaredTunnelToken", "");
} catch (error) { }
} catch (error) {
log.error("cloudflared", "Error in removeToken handler: " + error.message);
}
});
};